fix: folder picker activity empty list state #15818
Merged
+33
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
add/idle-empty-list-state
branch
from
3e31c59 to
ce23a08
Compare
alperozturk96
changed the title
alperozturk96
force-pushed
the
add/idle-empty-list-state
branch
from
ce23a08 to
d2fc248
Compare
alperozturk96
force-pushed
the
add/idle-empty-list-state
branch
from
d2fc248 to
a9a00f0
Compare
alperozturk96
commented
Oct 21, 2025
| // in owncloud library with broadcast notifications pending to process | ||
| DataHolderUtil.getInstance().delete(intent.getStringExtra(FileSyncAdapter.EXTRA_RESULT)) | ||
| } finally { | ||
| listOfFilesFragment?.setEmptyListMessage(EmptyListState.LOCAL_FILE_LIST_EMPTY_FILE) |
There was a problem hiding this comment.
If ExtendedListFragment contains items, empty list state is not visible thus adding IDLE state in this PR out of scope. Maybe we can add via separate PR.
alperozturk96
commented
Oct 21, 2025
| user, | ||
| applicationContext | ||
| ) | ||
| operation.execute( |
There was a problem hiding this comment.
Previously, setBackgroundText() is called before waiting completion of the RefreshFolderOperation.
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15818.apk |
|
/backport to stable-3.34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Handles empty list state correctly in
FolderPickerActivityHow to reproduce?