Skip to content

Conversation

@jimlyas
Copy link

@jimlyas jimlyas commented Oct 28, 2025

Description

This Merge Include:

Migrating from Groovy DSL to Kotlin DSL

Migrate from Groovy to Kotlin DSL for the build script

  • build.gradle to build.gradle.kts
  • jacoco.gradle to jacoco.gradle.kts
  • settings.gradle to settings.gradle.kts
  • app/build.gradle to app/build.gradle.kts
  • appscan/build.gradle to appscan/build.gradle.kts

there's some improvement to like grouping some configuration and setup in one place.

Generating jacoco report task

Previously, the project run generate report task to trigger the unit test task.

This PR reverse that, so we only need to run the unit test and after it finished, then Gradle will run the task that generate jacoco report.

Another reason being is, when running the unit test task, Android Studio will display Run Test window that help visibility to see which task is passed and which task is failed.

Version Catalog

  • Migrate from extras-based versioning to use version catalog for versioning
  • Implement all the convention Gradle plugin from version catalog
  • Group dependencies together using bundles
  • Tests written, or not not needed

@jimlyas jimlyas changed the title chore(gradle): Improve Gradle Configuration Chore: Improve Gradle Configuration Oct 28, 2025
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you for your PR.

We are using Renovate Bot, and dependency versions are continuously changing. This means that after this conversion, some dependencies in your PR may become outdated. To address this, your PR will need to be updated, and in the meantime, Renovate Bot might merge other dependency updates as well.

To make the process smoother and reduce potential conflicts, I would suggest breaking this PR into smaller, more focused sections, such as:

  • jacoco.gradlejacoco.gradle.kts
  • settings.gradlesettings.gradle.kts
  • appscan/build.gradleappscan/build.gradle.kts
  • app/build.gradleapp/build.gradle.kts
  • libs.versions.toml (this is the most complex one, as it also requires checking versions along with verification-metadata.xml)

By splitting the changes into smaller parts, we can progress more efficiently rather than doing everything at once.

Thank you for your understanding and effort on this.

@jimlyas jimlyas requested a review from alperozturk96 October 29, 2025 12:20
Jimly Asshiddiqy added 4 commits October 30, 2025 13:36
- Rename build.gradle to build.gradle.kts
- Rename settings.gradle to settings.gradle
- Rename jacoco.gradle to jacoco.gradle.kts
- Refactor some entries in the libs.versions.toml
- Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task

Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
@alperozturk96 alperozturk96 merged commit dd87b21 into nextcloud:master Oct 30, 2025
14 of 18 checks passed
@jimlyas jimlyas deleted the chore/gradle-new branch October 30, 2025 08:22
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.35.0 milestone Oct 30, 2025
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants