-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Chore: Improve Gradle Configuration #15859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0cbcd2 to
0d82588
Compare
alperozturk96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thank you for your PR.
We are using Renovate Bot, and dependency versions are continuously changing. This means that after this conversion, some dependencies in your PR may become outdated. To address this, your PR will need to be updated, and in the meantime, Renovate Bot might merge other dependency updates as well.
To make the process smoother and reduce potential conflicts, I would suggest breaking this PR into smaller, more focused sections, such as:
jacoco.gradle→jacoco.gradle.ktssettings.gradle→settings.gradle.ktsappscan/build.gradle→appscan/build.gradle.ktsapp/build.gradle→app/build.gradle.ktslibs.versions.toml(this is the most complex one, as it also requires checking versions along withverification-metadata.xml)
By splitting the changes into smaller parts, we can progress more efficiently rather than doing everything at once.
Thank you for your understanding and effort on this.
- Rename build.gradle to build.gradle.kts - Rename settings.gradle to settings.gradle - Rename jacoco.gradle to jacoco.gradle.kts - Refactor some entries in the libs.versions.toml - Change running test task from to run jacoco task to trigger task, now it's reversed... we run the test task that will trigger the jacoco task Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
Signed-off-by: Jimly Asshiddiqy <jimly.asshiddiqy@accenture.com>
7cd88e2 to
96debdd
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Description
This Merge Include:
Migrating from Groovy DSL to Kotlin DSL
Migrate from Groovy to Kotlin DSL for the build script
there's some improvement to like grouping some configuration and setup in one place.
Generating jacoco report task
Previously, the project run generate report task to trigger the unit test task.
This PR reverse that, so we only need to run the unit test and after it finished, then Gradle will run the task that generate jacoco report.
Another reason being is, when running the unit test task, Android Studio will display Run Test window that help visibility to see which task is passed and which task is failed.
Version Catalog