Skip to content

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Dec 10, 2025

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need something in the frontend to toggle is_remembered for a session, right?

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…nAPI annotation

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind, I pushed a few commits to fix a typo and adjust the "update chat session" controller method.

@janepie
Copy link
Member

janepie commented Dec 12, 2025

So we need something in the frontend to toggle is_remembered for a session, right?

Added, but it doesn't end up in the db, any idea why?

@marcelklehr
Copy link
Member Author

Can you push your code?

janepie and others added 3 commits December 12, 2025 15:12
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr changed the title feat: Implement the backend for memories feat: Implement memories Dec 15, 2025
@marcelklehr
Copy link
Member Author

Screenshot From 2025-12-15 09-18-42 Screenshot From 2025-12-15 09-18-34

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you've been able to do it like this in the end!

I would avoid complicating the default interface further and put this in the ... menu as an NcActionButton type="radio". It basically can behave like a switch

Screen.Recording.2025-12-16.at.16.14.16.mov

For the action icon I think it's fine to use this

@janepie
Copy link
Member

janepie commented Dec 16, 2025

I would avoid complicating the default interface further and put this in the ... menu as an NcActionButton

Feels like no one will ever see or use this then

@julien-nc
Copy link
Member

I hope you don't mind me pushing here. @janepie and me found out the custom setter was the issue. It somehow changes 0 to '' when updating the entity. It works fine with the magic setter method.

…isRemembered and isSummaryUpToDate

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ssion's isRemembered and isSummaryUpToDate"

This reverts commit 1ef3c0f.
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Copy link
Member Author

I would avoid complicating the default interface further and put this in the ... menu as an NcActionButton

Feels like no one will ever see or use this then

mmh, I sort of agree. Hiding it in the ... menu makes it less likely for people to discover it :/

@marcoambrosini
Copy link
Member

Feels like no one will ever see or use this then

Copying from internal chat on the topic:
From my PoV it's ok. We also have not tested the usefulness of of this in the real world so I would prefer a conservative approach of having it behind a menu until we know it's really good and useful. We can always pop it out of the action menu as an unlabelled (or even labelled) button if we get lots of requests or when the feature is more mature.

Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
@janepie
Copy link
Member

janepie commented Dec 22, 2025

Added a summary list in the personal settings

image

Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
@janepie
Copy link
Member

janepie commented Dec 23, 2025

We also have not tested the usefulness of of this in the real world so I would prefer a conservative approach of having it behind a menu until we know it's really good and useful. We can always pop it out of the action menu as an unlabelled (or even labelled) button if we get lots of requests or when the feature is more mature.

@marcoambrosini We develop it for people to use it and we want it to be seen and used. Do you have any proposal for a location that is less "disruptive" and still visible?

I changed the icon to the memory one (like that!), as it doesn't have a filled version I adapted the text to change to Remembered when clicked, wdyt?

Screenshot_20251223_105549 image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants