Skip to content

Fix: use new composable for relative time #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janepie merged 1 commit into from
Dec 17, 2025
Merged

Fix: use new composable for relative time #429

janepie merged 1 commit into from
Dec 17, 2025

Conversation

@janepie
Copy link
Member

@janepie janepie commented Dec 17, 2025

The moments library uses the locale instead of the language for localization, fixed with the vue composable
See nextcloud-libraries/nextcloud-moment#1061

image

@janepie
fix: use new composable for relative time
13bd4b0 
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
julien-nc
julien-nc approved these changes Dec 17, 2025
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine 👍

@julien-nc
Copy link
Member

julien-nc commented Dec 17, 2025

We also use moment.fromNow() in:

  • integration_github
  • integration_gitlab
  • integration_zammad

marcelklehr
marcelklehr approved these changes Dec 17, 2025
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@janepie
Copy link
Member Author

janepie commented Dec 17, 2025

We also use moment.fromNow() in:

* integration_github

* integration_gitlab

* integration_zammad

I will open tickets there

This was referenced Dec 17, 2025
Open
Open
Open
@janepie janepie merged commit fd3aa1c into main Dec 17, 2025
9 checks passed
@janepie janepie deleted the fix/time-locale branch December 17, 2025 12:52
@julien-nc
Copy link
Member

julien-nc commented Dec 17, 2025

Thank you!

@janepie janepie mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@julien-nc julien-nc julien-nc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janepie @julien-nc @marcelklehr