use inverse background color for result_title#676
Open
Chaosmeister wants to merge 1 commit intonextcloud:masterfrom
Open
use inverse background color for result_title#676Chaosmeister wants to merge 1 commit intonextcloud:masterfrom
Chaosmeister wants to merge 1 commit intonextcloud:masterfrom
Conversation
In dark theme, the black color was not easily readable. With additional high contrast mode, the title could not be read at all. This change uses the inverse background color and should be readable in both cases. As long as there's only these two themes available, this solution should suffice Signed-off-by: Tomas Dittmann <chaosmeist3r@gmail.com>
mahoneyr
approved these changes
Oct 30, 2022
|
I think this could work: .result_title {
color: var(--color-main-text);
}
.result_extract {
color: color-mix(in srgb, var(--color-main-text), var(--color-main-background) 15%);
}
.provider_navigation {
color: color-mix(in srgb, var(--color-main-text), var(--color-main-background) 20%);
}
.result_entry {
border-bottom: solid 1px color-mix(in srgb, var(--color-main-text), var(--color-main-background) 75%);
}This approach looks more aesthetically pleasing. |
Author
nearly 3 years already I've used this in our instance without a problem. I'm going to try your implementation though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dark theme, the black color was not easily readable.
With additional high contrast mode, the title could not be read at all.
This change uses the inverse background color and should be readable in both cases.
As long as there's only these two themes available, this solution should suffice