perf(quick-actions): eliminate duplicate api calls for each envelope #11945
+82
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
changed the title
hamza221
force-pushed
the
perf/quick-actions
branch
from
8be1b55 to
c94ffa6
Compare
hamza221
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
Contributor
Author
|
Ci needs some tweaking |
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
perf/quick-actions
branch
from
c94ffa6 to
94959ca
Compare
…velope Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
lib/Service/QuickActionsService.php
Outdated
Comment on lines
43
to
45
| $actions = $this->actionsMapper->findAll($userId); | ||
| foreach ($actions as $action) { | ||
| $actionSteps = $this->actionStepMapper->findAllStepsForOneAction($action->getId(), $userId); |
Member
There was a problem hiding this comment.
perf: n+1 problem
you could fetch the steps in bulk with a WHERE action_id IN (...)
…velope Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
…velope Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11746