Skip to content

[stable32] fix(files): improve handling of copy-move action#58130

Merged
susnux merged 2 commits intostable32from
backport/57993/stable32
Mar 3, 2026
Merged

[stable32] fix(files): improve handling of copy-move action#58130
susnux merged 2 commits intostable32from
backport/57993/stable32

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Feb 6, 2026

Backport of #57993

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Feb 6, 2026
@backportbot backportbot bot added this to the Nextcloud 32.0.6 milestone Feb 6, 2026
@susnux susnux marked this pull request as ready for review February 6, 2026 11:43
@susnux susnux requested review from a team and skjnldsv as code owners February 6, 2026 11:43
@susnux susnux marked this pull request as draft February 6, 2026 11:45
@susnux
Copy link
Contributor

susnux commented Feb 6, 2026

(different code base than master and 33 - needs more heavy adjustments)

@susnux susnux force-pushed the backport/57993/stable32 branch from 8a8a331 to a26d6db Compare March 3, 2026 01:26
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

1. only show 1 loading toast instead of N for N files in batch
   operation.
2. Reuse more code to reduce duplicated logic.
3. Show the conflict picker once for all files instead of opening a new
   conflict picker for every file to copy / move.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/57993/stable32 branch from a26d6db to cf76fa5 Compare March 3, 2026 11:45
@susnux
Copy link
Contributor

susnux commented Mar 3, 2026

/compile

@susnux susnux marked this pull request as ready for review March 3, 2026 11:45
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 81ffc74 into stable32 Mar 3, 2026
134 of 137 checks passed
@susnux susnux deleted the backport/57993/stable32 branch March 3, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants