style(buttons): remove conflicting !important style from Dashboard App#58684
Open
Arsalanulhaq wants to merge 1 commit intomasterfrom
Open
style(buttons): remove conflicting !important style from Dashboard App#58684Arsalanulhaq wants to merge 1 commit intomasterfrom
Arsalanulhaq wants to merge 1 commit intomasterfrom
Conversation
Arsalanulhaq
requested review from
artonge,
skjnldsv and
szaimen
and removed request for
a team
…round color for cleaner CSS Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
Arsalanulhaq
force-pushed
the
fix/remove_conflicting_important_style
branch
from
e7ea633 to
acb9547
Compare
Contributor
|
screenshots do not look like they are from current master? Also I cannot reproduce the issue you try to fix, unpatched current master: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes a minor update to the styling in
DashboardApp.vue, specifically by removing the!importantflag from thebackground-colorproperty for hover, focus, and active states as it conflicts with the dashboard buttons (specifically weather) active state.Before:
After:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)