feat: add calendar name to search entries#58697
Open
SebastianKrupinski wants to merge 1 commit intomasterfrom
Open
feat: add calendar name to search entries#58697SebastianKrupinski wants to merge 1 commit intomasterfrom
SebastianKrupinski wants to merge 1 commit intomasterfrom
Conversation
SebastianKrupinski
requested review from
Altahrim,
ChristophWurst,
DerDreschner,
GVodyanov,
hamza221,
leftybournes,
nfebe,
salmart-dev and
tcitworld
and removed request for
a team
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
feat/add-calendar-name-to-search-result
branch
from
25ecf28 to
c232953
Compare
tcitworld
reviewed
Mar 3, 2026
| if ($this->isDayEqual($startDateTime, $endDateTime)) { | ||
| return "$formattedStartDate $formattedStartTime - $formattedEndTime"; | ||
| if (isset($calendarInfo['{DAV:}displayname']) && !empty($calendarInfo['{DAV:}displayname'])) { | ||
| $formattedSubline = $formattedSubline . " ({$calendarInfo['{DAV:}displayname']})"; |
Member
There was a problem hiding this comment.
Maybe always simply fallback to calendar URI if no display name ?
kesselb
approved these changes
Mar 3, 2026
Member
|
@SebastianKrupinski Could you do the same thing for tasks while we're at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)