📆 Show "Next meeting" in the chat

[AndyScherzinger]

• Please see 🪟 Meta info display in rooms #5867 for discussion first

---

• Resolves Show "Next meeting" in the chat #5661
• Follows the implementation approach of the out-of-office feature
• Reuses the scheduled-call feature date-formatting logic
• Uses a generic copyright header, like we do in other non-mobile projects (can also switch to personal ones if you like)
• Add persistence to store info when dismissed with key o id+summary+time, so when any of it changes it will be displayed again

🖼️ Screenshots

🕸️ Web	🏚️ Before	🏡 After

🚧 TODO

• review & merge

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[jancborchardt]

It looks different from the message pinning style as far as I can see? Or does it work well in conjunction with that?
#5807

2 floating boxes would be fine. Ideal could be one floating box with a horizontal divider line, to save on space and visual complexity.

[jancborchardt]

Nevermind – saw #5867 just now :)

[mahibi]

Would be nice to already follow the suggestion from #5867 (comment) to make it collapsible?
Otherwise fine for me to do this in followup PRs.

[AndyScherzinger]

Would be nice to already follow the suggestion from #5867 (comment) to make it collapsible?
Otherwise fine for me to do this in followup PRs.

@mahibi Yes, I will simply change it according to the discussion on the other item 👍

Yet I am unsure if that means, hide it forever? hide until you open the chat again or hide it based on the date of the event you display?

WDYT @jancborchardt @nimishavijay ?

[jancborchardt]

Yet I am unsure if that means, hide it forever? hide until you open the chat again or hide it based on the date of the event you display?

Probably best would be to:

• ✅ Always anyway show the "Upcoming call" box in the "Conversation info" view. Directly between conversation description and "Notification settings".
• ✅ If you x away the "Upcoming call" box that shows directly in the conversation view, show a notice saying "Upcoming call can be viewed in conversation info".

[AndyScherzinger]

@mahibi implemented database layer change for dismissing and updated the design as discussed in the general design issue

fixed review comments

[jancborchardt]

Looks good!

This should be added as follow-up :) #5865 (review)

[mahibi]

So this is the point where we begin to store local-only things in the same entity that is fed by the api.
That's okay of course. We would have to make sure this is handled everywhere where we use the endpoint which can easily be forgotten.

I'm just thinking if we should have a rule how we should do this in general.
What about to have this handled by mappers?
For example the mapper from ConversationModel to ConversationEntity could look like:

fun ConversationModel.asEntity(existing: ConversationEntity?): ConversationEntity {
    return ConversationEntity(
        internalId = internalId,
        accountId = accountId,
       ....

        // here, we could handle all "local-only" fields
        hiddenUpcomingEvent = existing?.hiddenUpcomingEvent ?: false
    )
}

With this, we won't accidentally forget to rescue specific columns from being overwritten.

What do you think @AndyScherzinger ?

[AndyScherzinger]

In general it makes sense to discuss that, yes.

If I am not mistaken than messageDraft is local-only as well, no?

[AndyScherzinger]

See
https://github.com/nextcloud/talk-android/blob/feat/5661/nextMeeting/app/src/main/java/com/nextcloud/talk/models/domain/ConversationModel.kt#L70-L73

So it is field no3 😆

[mahibi]

Okay i see, the idea wasn't quite fully developed yet :D
So fine for me to merge then

[AndyScherzinger]

Happy to discuss how to improve it 👍
The mapper does respect the fields, there just isn't a mapper with an entitled parameter input.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	98	98
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	54	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	81	81

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5865.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[mahibi]

/backport to stable-23.0