🗺️ Migrate location picker to composables

[AndyScherzinger]

• with custom zoom controls and
• dark mode support (discuss if it should be kept)
• visual revamp with search bar on top, current location moved to bottom and vertical zoom controls moved to the side on portrait and horizontal on landscape and also replaced the red pin using a different, less aggressive shade of red and a black outline

🖼️ Screenshots

🏚️ Before	🏡 After

🚧 TODO

• add screenshots
• max search bar max-width-ed to 720dp as per M3 guide
• review design
• review code

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[AndyScherzinger]

The dark mode of the map might be debatable @jancborchardt since it interferes with the search bar. I could make that the same color as the bottom element (surface container highest instead or high) while that would not be according to M3 spec, but not an issue per se.

[jancborchardt]

Looks good.

In landscape mode there could be some space saved by not making the "Share location" box full width but keeping some space for the zoom and location buttons.

If it's according to spec as is, that's fine though.

[AndyScherzinger]

In landscape mode there could be some space saved by not making the "Share location" box full width but keeping some space for the zoom and location buttons.

@jancborchardt Added with the last push 👍

[mahibi]

What about outlined buttons/cards to no interfere with the map?
Or/and add a shadow.
The floating button currently has a shadow by default, the others not.

some optional gimmick for later follow ups maybe:
would be nice if the pin is lifted when the map is dragged, and dropped when dragging ends. And add a shadow where the pin sticks. This is how it's done on signal.

Also btw: it seems that geocoding search is broken, also on master. Maybe last minute changes from #5864 ?

[AndyScherzinger]

@mahibi outlined buttons for which ones? Zoom. controls or the fab?

The geo search results I also detected but didn't have the time yet to look into it again yet, let me find someone time for that 👍

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5893.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	99	99
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	54	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	81	81