⚒️ Migrate fullscreen viewer layout to Composables#5898
Merged
AndyScherzinger merged 7 commits intomasterfrom Mar 6, 2026
Merged
⚒️ Migrate fullscreen viewer layout to Composables#5898AndyScherzinger merged 7 commits intomasterfrom
AndyScherzinger merged 7 commits intomasterfrom
Conversation
AndyScherzinger
added
3. to review
AndyScherzinger
force-pushed
the
chore/noid/migrateFullScreenText
branch
2 times, most recently
from
3bcd763 to
4662974
Compare
AndyScherzinger
force-pushed
the
chore/noid/migrateFullScreenText
branch
2 times, most recently
from
8a8741a to
3511d90
Compare
AndyScherzinger
force-pushed
the
chore/noid/migrateFullScreenText
branch
2 times, most recently
from
c474ae8 to
497568d
Compare
AndyScherzinger
added
enhancement
AndyScherzinger
changed the title
AndyScherzinger
force-pushed
the
chore/noid/migrateFullScreenText
branch
5 times, most recently
from
8ffdec9 to
2be732f
Compare
jancborchardt
approved these changes
Mar 3, 2026
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice!
(Seems same is needed in the Nites app to fix the bug of the title being overlaid by the status bar?)
Member
Author
|
@jancborchardt the notes app is also fixed. @alperozturk96 did that, you might just not yet get the latest version via f-droid. |
AndyScherzinger
force-pushed
the
chore/noid/migrateFullScreenText
branch
from
2be732f to
cfba531
Compare
mahibi
previously requested changes
Mar 6, 2026
Collaborator
mahibi
left a comment
mahibi
left a comment
There was a problem hiding this comment.
-
Image zooming is broken
-
menu in FullScreenMediaScreen has wrong colors
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…ia Files app within the full screen activity Resolves #1683 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…ottom gradients for any bar when viewing the image Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
chore/noid/migrateFullScreenText
branch
from
cfba531 to
5a1f596
Compare
Member
Author
✅ Works for me, you need to double-tap first - same on master
👀 Looking into it |
…ad of hardcoded dark theme (not fully applying to menu) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Author
mahibi
approved these changes
Mar 6, 2026
Collaborator
|
created #5935 as this popped up during testing |
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5898.apk |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x