Skip to content

⚒️🎨 Migrate user info details to Composables#5931

Merged
AndyScherzinger merged 1 commit intomasterfrom
style/noid/userInfoDetailItemComposables
Mar 6, 2026
Merged

⚒️🎨 Migrate user info details to Composables#5931
AndyScherzinger merged 1 commit intomasterfrom
style/noid/userInfoDetailItemComposables

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Mar 5, 2026

... style like latest expressive M3 contacts.

I'll be splitting the work on migrating to composables as a first modernization step into several UI-targeting PRs. This is the 1st.

Remark

You might spot that disabled input field that is because that field has never been editable but the former UI did not make that transparent. For the sake of dev speed I kept the logic as is. For further reference - we could also think about a filter on the adapter that is currently in place for view mode hiding items with no values in them and could extend that one for edit mode hiding elements without editing permission.

Remark2

On initial change you'll face http400 errors to to a server behavior change requesting re-authenticaiton via password confirmation which the clients doesn't do yet. This is also broken on master/older releases and I would like this PR not to be blocked by that. In order to test, first go to the web interface and change a value, after prompted for your password and submitted, you can start changing/adding fields on the client.

Remark3

There is another pre-existing bug, invalid inputs will just be rejected showing a "saving failed" while looking at the frontend which implemented actual validation blocks on the frontend level. This is missing previous to this PR, so again, I would like this PR not to be blocked by that.

🖼️ Screenshots

🏚️ Before 🏡 After
before_light_read after_light_read
before_light_edit after_light_edit
before_dark_read after_dark_read
before_dark_edit after_dark_edit

🚧 TODO

  • implement editing capability (currently values are hard-reset upon editing)
  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 5, 2026
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews technical debt Technical issue labels Mar 5, 2026
@AndyScherzinger AndyScherzinger changed the title ⚒️🎨 Migrate user info details ⚒️🎨 Migrate user info details to Composables Mar 5, 2026
@AndyScherzinger AndyScherzinger added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 5, 2026
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, looks much better. Just one detail – the email address should ellipsize instead of breaking into multiple lines. Especially here with only the ".com" in the second line it looks off.

@AndyScherzinger AndyScherzinger force-pushed the style/noid/userInfoDetailItemComposables branch 4 times, most recently from 481485f to c9ee8d9 Compare March 6, 2026 00:49
@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Mar 6, 2026

Very nice, looks much better. Just one detail – the email address should ellipsize instead of breaking into multiple lines. Especially here with only the ".com" in the second line it looks off.

@jancborchardt fixed 👍 (did not update the screenshots though)

@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 6, 2026
@AndyScherzinger AndyScherzinger force-pushed the style/noid/userInfoDetailItemComposables branch 4 times, most recently from 86b84e6 to e1b8f9c Compare March 6, 2026 11:40
@mahibi
Copy link
Collaborator

mahibi commented Mar 6, 2026

when editing, the keyboard overlaps the fields address, website and "X" aka twitter (btw i absolutely agree with nextcloud/server#50841 (comment))

in the old behavior, the fields that are being edited scrolled up so they were seen above the keyboard

…ressive M3 contacts

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the style/noid/userInfoDetailItemComposables branch from e1b8f9c to f5464c8 Compare March 6, 2026 13:12
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5931.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@AndyScherzinger AndyScherzinger merged commit 8f45853 into master Mar 6, 2026
18 of 19 checks passed
@AndyScherzinger AndyScherzinger deleted the style/noid/userInfoDetailItemComposables branch March 6, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants