⚒️🎨 Migrate user info details to Composables#5931
Conversation
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice, looks much better. Just one detail – the email address should ellipsize instead of breaking into multiple lines. Especially here with only the ".com" in the second line it looks off.
481485f to
c9ee8d9
Compare
@jancborchardt fixed 👍 (did not update the screenshots though) |
86b84e6 to
e1b8f9c
Compare
|
when editing, the keyboard overlaps the fields address, website and "X" aka twitter (btw i absolutely agree with nextcloud/server#50841 (comment)) in the old behavior, the fields that are being edited scrolled up so they were seen above the keyboard |
…ressive M3 contacts Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
e1b8f9c to
f5464c8
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5931.apk |

... style like latest expressive M3 contacts.
I'll be splitting the work on migrating to composables as a first modernization step into several UI-targeting PRs. This is the 1st.
Remark
You might spot that disabled input field that is because that field has never been editable but the former UI did not make that transparent. For the sake of dev speed I kept the logic as is. For further reference - we could also think about a filter on the adapter that is currently in place for view mode hiding items with no values in them and could extend that one for edit mode hiding elements without editing permission.
Remark2
On initial change you'll face http400 errors to to a server behavior change requesting re-authenticaiton via password confirmation which the clients doesn't do yet. This is also broken on master/older releases and I would like this PR not to be blocked by that. In order to test, first go to the web interface and change a value, after prompted for your password and submitted, you can start changing/adding fields on the client.
Remark3
There is another pre-existing bug, invalid inputs will just be rejected showing a "saving failed" while looking at the frontend which implemented actual validation blocks on the frontend level. This is missing previous to this PR, so again, I would like this PR not to be blocked by that.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x