Skip to content

🪪 Add further profile items including enablement switch#5936

Merged
mahibi merged 2 commits intomasterfrom
feat/noid/profileFields
Mar 10, 2026
Merged

🪪 Add further profile items including enablement switch#5936
mahibi merged 2 commits intomasterfrom
feat/noid/profileFields

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Mar 6, 2026 •
edited
Loading

  • Add all other profile fields + icons and enable/disable profile (new composable)
  • fetches the profile data to display also in case editing permissions can be fetched or end up in an error

The mixed language is due to the lack of translations, which would happen after the merge via transifex.

🖼️ Screenshots

Description 🏡 Screenshot
Top read Screenshot_20260306_175858
Bottom read Screenshot_20260306_175922
Top edit Screenshot_20260306_175935

🚧 TODO

  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added design Related to the design 2. developing Work in progress labels Mar 6, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch 2 times, most recently from a9ee2cd to fe7ae84 Compare March 6, 2026 18:53
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 6, 2026
@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 6, 2026
@AndyScherzinger AndyScherzinger marked this pull request as ready for review March 6, 2026 19:04
@AndyScherzinger AndyScherzinger changed the title Add further profile items including enablement switch 🪪 Add further profile items including enablement switch Mar 6, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch from fe7ae84 to a4751a4 Compare March 6, 2026 19:06
jancborchardt
jancborchardt previously requested changes Mar 8, 2026
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment •
edited by AndyScherzinger
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

Small things:

  • We use American English, so "Organization" with z instead of "Organisation".
  • The right side of the "Enable profile" box in edit mode seems a bit unaligned with everything else. Is it correct?

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch 2 times, most recently from 44135e0 to 8bf7bb9 Compare March 8, 2026 09:23
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch from 8bf7bb9 to 6eec609 Compare March 8, 2026 12:43
mahibi
mahibi previously requested changes Mar 8, 2026
View reviewed changes
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch 2 times, most recently from e8cf958 to 18f9986 Compare March 8, 2026 22:51
@AndyScherzinger AndyScherzinger requested a review from mahibi March 8, 2026 22:52
@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Mar 8, 2026

@mahibi fixed your comments and also added edit state preservation upon screen rotation (also not implemented before but now we have it)

@sowjanyakch sowjanyakch mentioned this pull request Mar 9, 2026
Open
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch from 18f9986 to 7d03a92 Compare March 9, 2026 21:31
@AndyScherzinger
feat(profile): Add further profile items including enablement switch
8fc51cc 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch from 7d03a92 to c422e56 Compare March 9, 2026 22:31
@AndyScherzinger AndyScherzinger dismissed mahibi’s stale review March 9, 2026 22:33

Review feedback has been implemented

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch from c422e56 to f77922f Compare March 9, 2026 23:05
@AndyScherzinger
fix(profile): Add missing element to landscape profile and adapt to t…
580f830 
…he grown number of items

...and ensure device rotation preserves the editing/red-only state and removed unneeded lifecycle mgmt

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/profileFields branch from f77922f to 580f830 Compare March 9, 2026 23:12
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5936.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Codacy

Lint

TypemasterPR
Warnings9998
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@mahibi mahibi merged commit 8fe285c into master Mar 10, 2026
19 of 22 checks passed
@mahibi mahibi deleted the feat/noid/profileFields branch March 10, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch sowjanyakch approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Milestone

23.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyScherzinger @jancborchardt @mahibi @sowjanyakch