feat: handle the themes/ folder contents possibly not writable #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The themes/ content, apart from the default content, contains admin-defined content, which may not be writable. A use case is versionning the theme with git, and files in .git may not be writable. This handles this as best as possible. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Altahrim
approved these changes
Nov 3, 2025
come-nc
approved these changes
Nov 3, 2025
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
handle-themes-content-not-writable
branch
from
399ae88 to
5e8aae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
themes/content, apart from the default content, contains admin-defined content, which may not be writable. A use case is versioning the theme with git, and files in.gitmay not be writable. This handles this as best as possible.