ci: add CI workflow and Makefile targets#41
Open
vanducng wants to merge 2 commits intonextlevelbuilder:mainfrom
Open
ci: add CI workflow and Makefile targets#41vanducng wants to merge 2 commits intonextlevelbuilder:mainfrom
vanducng wants to merge 2 commits intonextlevelbuilder:mainfrom
Conversation
Add GitHub Actions CI workflow with two parallel jobs: - Go: build, test (-race), vet - Web UI: pnpm install, tsc + vite build Triggered on PRs and pushes to main. Add Makefile targets: test, vet, lint-web, setup, ci for local pre-PR validation via `make ci`.
Capture keepaliveDone channel in local variable before select loop to avoid racing with forceStop's nil assignment under mutex. Detected by go test -race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yaml) with two parallel jobs:-race) + vettest,vet,lint-web,setup,ci-raceflag)Details
go.mod, pnpm version pinned to 10permissions: contents: readfor least-privilegemake cimirrors GHA checks locally for pre-PR validationTest plan
make cipasses locally (build + test -race + vet + lint-web)go test -race -count=5Closes #36