[dev] reverse proxy #2035
Merged
[dev] reverse proxy #2035
+66
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-james-reverse-p-ixbf6j
Running with `auspice view --handlers cli/dev/reverse-proxy.js` will proxy all requests to localhost:5000 by default, allowing you to run a local nextstrain.org server and test against a new Auspice client. Specifying the env variable `PROXY="https://nextstrain.org"` easily allows you to use the live nextstrain.org host as the charon API, allowing easy testing of nextstrain.org functionality such as groups, community etc. This essentially closes #2033. There's one (niche!) use-case where you may want to source narratives locally (i.e. default Auspice server behaviour) but their datasets through a proxy. If I ever need to reach for that particular behaviour I'll revisit this.
The behaviour of this code is now available via custom server (API) handlers introduced in the previous commit.
jameshadfield
force-pushed
the
james/reverse-proxy
branch
from
85ba05b to
3cba701
Compare
jameshadfield
temporarily deployed
to
auspice-james-reverse-p-ixbf6j
Member
|
Tested locally, works great! Small low-priority suggestion, feel free to take or leave: ce0e70b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running with
auspice view --handlers cli/dev/reverse-proxy.jswill proxy all requests to localhost:5000 by default, allowing you to run a local nextstrain.org server and test against a new Auspice client. Specifying the env variablePROXY="https://nextstrain.org"easily allows you to use the live nextstrain.org host as the charon API, allowing easy testing of nextstrain.org functionality such as groups, community etc.This essentially closes
#2033. There's one (niche!) use-case where you may want to source narratives locally (i.e. default Auspice server behaviour) but their datasets through a proxy. If I ever need to reach for that particular behaviour I'll revisit this.