Version 2.0.0 Release #153
Conversation
modules and subworkflows
Add modules
add module bcftools filter
Add RASUSA module
Add CLAIR3 module
Pre-release dev branch
pre-release dev
Joon-Klaps
left a comment
Joon-Klaps
left a comment
There was a problem hiding this comment.
Very nice work, no major comments. Only suggestions.
| make_dir(out_dir) | ||
|
|
||
| ## Create list of fastq-scan json files | ||
| json_files = sorted(glob.glob('*.json')) |
There was a problem hiding this comment.
nitpicking
I think it would be better if you were to ask for an input dir in args and search there for json files instead of working dir.
| raw_json_files = sorted(glob.glob('*.raw.json')) | ||
|
|
||
| ## Create list of processed reads fastq-scan json files | ||
| processed_json_files = sorted(glob.glob('*.processed.json')) |
There was a problem hiding this comment.
nitpicking... again sorry
Same here, think it would be better if you were to ask for input params & use in nextflow the stageAs.
| { assert snapshot( | ||
| process.out.vcf.collect { file(it[1]).getName() }, | ||
| process.out.tbi.collect { file(it[1]).getName() }, | ||
| process.out.versions, | ||
| process.out.phased_vcf.collect { file(it[1]).getName() }, | ||
| process.out.phased_tbi.collect { file(it[1]).getName() }).match()} | ||
| ) |
There was a problem hiding this comment.
I'm guessing it's not stable due to the vcf header?
Might be interesting to use nft-vcf plugin with it's function .variantsMD5
There was a problem hiding this comment.
I'm not sure how to address this. This was the original main.nf.test from nf-core.
| process.out.phased_vcf.collect { file(it[1]).getName() }, | ||
| process.out.phased_tbi.collect { file(it[1]).getName() }).match()} |
There was a problem hiding this comment.
phased_vcf & phased_tbi their names are not stored in snapshot. It's an empty array.
There was a problem hiding this comment.
I'm not sure how to address this. This was the original main.nf.test from nf-core.
post pre-release review
update template files
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).