Skip to content

AngularJS is No More. #368

Open
RyCarpenter wants to merge 49 commits intodevelopfrom
feature/mage-1743-services
Open

AngularJS is No More. #368
RyCarpenter wants to merge 49 commits intodevelopfrom
feature/mage-1743-services

Conversation

@RyCarpenter
Copy link
Contributor

@RyCarpenter RyCarpenter commented Jan 20, 2026

AngularJS has been completely annihilated in favor of Angular 14.

This change requires EXTREME testing of the entire admin suite.

For EVERY Admin Page, the following Tests will need to be run, Yes EVERY page, as there can be subtle differences:

  • Check Breadcrumbs
  • Check Nav Placement
    • Make sure to attempt to scroll, the page should go under breadcrumbs and the menu button should be attached to the breadcrumbs bar
  • Make Sure UI Loads Correctly, nothing looks wonky or out of place

For all DASHBOARD style pages, please test the following:

  • Table Loads with Correct Data
  • Links inside Table Work
  • New (OBJECT) Buttons Work and creation brings up a new Toast Linking to the new Object
  • Filtering Works
  • Any supplementary Buttons work (think the Bulk Import for users)

For all DETAILS Pages:

  • Ensure all data loads and is Correct
  • Ensure all Links Work

Additional things to think of:

  • Pagination should work
  • Inner Pages may have unique requirements, adjust to them
  • Do NOT forget to test the plugins, they should work as well.
  • Make sure settings changes save when the button is clicked

Overall this is just a base guide of things you should check, the correct method for something like this involves clicking EVERYTHING. This is not something we can just look at code for, if you are just looking at the code for this change, you are not testing it, it needs a full thorough runthrough.

@RyCarpenter RyCarpenter marked this pull request as ready for review January 27, 2026 18:00
@RyCarpenter RyCarpenter changed the title [Draft] AngularJS is No More. AngularJS is No More. Feb 2, 2026
@ryanslatten
Copy link
Contributor

So far I've only found CSS issues. Here are a few

The Menu button is not aligned with the breadcrumbs
Screenshot 2026-02-02 at 9 46 32 PM

The Admin login button seems too small. Just need to expand the sizing
Screenshot 2026-02-02 at 9 47 30 PM

The logins table on the devices page seems smaller now
Screenshot 2026-02-03 at 7 53 29 AM

@ryanslatten
Copy link
Contributor

The Create Team modal is missing styling from the other modals. The Event modal also has a similar styling issue. All the create modals should probably look like the create user modal.
Screenshot 2026-02-03 at 2 44 00 PM

In the feeds dashboard it looks like the CSS is messed up
Screenshot 2026-02-03 at 2 45 14 PM

The Register Device button is not working on the Device details page. Unregistering the device doesn't update the local state either
Screenshot 2026-02-03 at 2 54 57 PM

The Add Member search modals are also too small.
Screenshot 2026-02-03 at 2 57 54 PM

Clicking on a Team from the Event Details page takes you to the dashboard instead of the Team details page.

@S-S-T
Copy link
Contributor

S-S-T commented Feb 4, 2026

In ADMIN: Layers page: The Add Event Dialog is missing the standard background color:

Screenshot 2026-02-04 at 2 41 06 PM

@S-S-T
Copy link
Contributor

S-S-T commented Feb 4, 2026

Create New TEAM Button inconsistency? For each Create New button that opens up a dialog, the dialog has 2 buttons at the bottom one light and one blue one for the +create operation. This is true for New User, New Event, New Form, New Device and New Layer. Create New Team does not have this. Both buttons are light/opaque. Is this intended?

Screenshot 2026-02-04 at 2 52 44 PM Screenshot 2026-02-04 at 2 34 49 PM Screenshot 2026-02-04 at 2 34 36 PM

ryanslatten
ryanslatten previously approved these changes Feb 4, 2026
Copy link
Contributor

@ryanslatten ryanslatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@S-S-T
Copy link
Contributor

S-S-T commented Feb 5, 2026

Page rendering issue: In ADMIN/Users page, if you click on the User row and wish to edit the User, everything is good, there is a Delete User Account panel w/ red background and button that is correctly aligned. If user goes in and makes an edit to the User and saves it, the post-save page now has an odd-looking Delete User Account w/ an unnecessary ScrollBar on the right side. Granted, the scrollbar does disappear after a page reload, or if you navigate a away from and then return to the page, but it seems like a tweak may be in order.

-----> Before Edit: (note original display name and Delete User Account panel)
Screenshot 2026-02-05 at 7 13 24 AM

-----> After Edit/Save: (note new display name and Delete User Account panel now w/ scrollbar)
Screenshot 2026-02-05 at 7 12 42 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants