Skip to content

Conversation

@markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Oct 12, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit a056720
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/68ebc49b0be326000894b46c

@netlify
Copy link

netlify bot commented Oct 12, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit a056720
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/68ebc49b8967570008066747
😎 Deploy Preview https://deploy-preview-4978--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@markostanimirovic markostanimirovic changed the title feat(events): provide Dispatcher and Events at the platform level feat(signals): provide Dispatcher and Events at the platform level Oct 12, 2025
@timdeschryver
Copy link
Member

After approving, I was wondering if this could lead to a breaking change when someone bootstraps 2 applications?

@markostanimirovic
Copy link
Member Author

As we talked, breaking changes are not expected since bootstrapping multiple apps on the same page would be a rare case. Even though they happen, the Events plugin is still experimental, and we want to enable its use in the platform-level SignalStores.

@markostanimirovic markostanimirovic merged commit 0722ddb into main Oct 18, 2025
14 checks passed
@markostanimirovic markostanimirovic deleted the feat/events/provide-dispatcher-at-the-platform-level branch October 18, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants