Update ni-apis submodule .proto files to latest versions #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
added 2 commits
November 11, 2025 13:57
dixonjoel
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ni-apis submodule to incorporate the latest .proto file changes, specifically field renamings to improve clarity and consistency across the measurement APIs. The changes rename plural extensions to singular extension and improve specificity by renaming generic fields like type to more descriptive names like condition_type, value_type, and step_type.
Key Changes:
- Renamed
extensionsfield toextensionacross all metadata and data entities - Renamed ambiguous
typefields to more specific names (condition_type,value_type,step_type) - Updated documentation strings to provide clearer guidance on extension usage
- Simplified schema_id documentation by removing context-specific conditions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/ni-apis | Updates submodule pointer to latest commit containing field name improvements |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_pb2/init.pyi | Updates type stubs to reflect field renamings: extensions → extension and class name changes from ExtensionsEntry → ExtensionEntry |
| packages/ni.measurements.metadata.v1.proto/src/ni/measurements/metadata/v1/metadata_store_pb2/init.py | Updates generated Python code with new field names and serialization offsets |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_pb2/init.pyi | Updates type stubs with field renamings: type → condition_type/value_type/step_type, extensions → extension |
| packages/ni.measurements.data.v1.proto/src/ni/measurements/data/v1/data_store_pb2/init.py | Updates generated Python code with new field names and serialization offsets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jfriedri-ni
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Gets latest changes from ni-apis, specifically including ni/ni-apis#141.
Why should this Pull Request be merged?
Updates field names and keeps us up-to-date with the .proto files. Subsequently we will
ni.measurements.data.v1.proto,ni.measurements.metadata.v1.protoni.measurements.data.v1.client,ni.measurements.metadata.v1.clientWhat testing has been done?
PR checks