-
Notifications
You must be signed in to change notification settings - Fork 99
Fixing size parameter handling in len-mechanism to handle function parameters with different size parameters #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
+ Coverage 81.72% 89.16% +7.44%
==========================================
Files 29 71 +42
Lines 4115 18968 +14853
==========================================
+ Hits 3363 16913 +13550
- Misses 752 2055 +1303
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 46 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
It seems we've gone from using flake8 7.1.2 to using flake8 7.3.0 and the new one has this new error code. https://docs.python.org/3/reference/simple_stmts.html#the-global-statement This seems like something we should address in a separate PR. |
You only need the https://stackoverflow.com/questions/291978/short-description-of-the-scoping-rules |
I have added a |
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
Fixes the codegen to properly handle functions with multiple array parameters that reference different size parameters:
Updates
metadata_filters.py: Refactors thefilter_parametersfunction to collect all size parameter names referenced by len-sized parameters into alen_size_parameter_names, replacing the previous singlelen_size_parameterapproach. Removed assert to check if all size parameters are same fromfilter_len_parameters. Following this updated var names indefault_method.py.makoandinitialization_method.py.makoto reflect multiple possible size params.Updates to nifake to enable testing: Details covered in testing section
Previously, it was assumed all len-mechanism arrays in a function shared the same size parameter. This change enables functions like
CreateDeembeddingSparameterTableArrayin NI-RFSG wherefrequenciesusesfrequenciesSizeandsparameterTableusessparameterTableSize.List issues fixed by this Pull Request
Issue 2137: Fix size parameter handling for functions with parameters referencing multiple size parameters.
Additional PR needs to be raised to update NI-RFSG function metadata (CreateDeembeddingSparameterTableArray) to consume
these changes.
What testing has been done?
MultipleArraysDifferentSizefunction to nifake metadata with two arrays (valuesArrayusingvaluesArraySize, anddataArrayusingdataArraySize) to test the change in filter param logictest_multiple_arrays_different_sizeintest_library_interpreter.pythat verifies correct handling of multiple arrays with independent size parametersvaluesArraywithvaluesArraySize, and 5 elements fordataArraywithdataArraySize)