fix: don't wait after timeout nor final attempt failed#135
Open
popcube wants to merge 1 commit intonick-fields:masterfrom
Open
fix: don't wait after timeout nor final attempt failed#135popcube wants to merge 1 commit intonick-fields:masterfrom
popcube wants to merge 1 commit intonick-fields:masterfrom
Conversation
Author
|
Hello pr name was misleading so I changed to the current one. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
=========================================
- Coverage 2.53% 2.50% -0.04%
=========================================
Files 3 3
Lines 158 160 +2
Branches 51 55 +4
=========================================
Hits 4 4
Misses 141 141
- Partials 13 15 +2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the bullet points below with your answers
Description
Skip waiting for [retry_wait_seconds] seconds for both timeout and attempt failure conditions when the remaining retry is zero.
It should save some computing resource and wait time.
Fixes #134
Testing
No test was added.