-
Notifications
You must be signed in to change notification settings - Fork 30
Pt layout #47
base: master
Are you sure you want to change the base?
Pt layout #47
Conversation
nick-shmyrev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, overal it looks great! Just a couple of tiny issues:
The "hide" key seems to "jump around" when you switch between lowercase and uppercase layers, and the arrow keys seem to be misaligned in uppercase level, see the 2 screenshots above.
I see you've tried to make sure the Symbols layer keys line up properly, nice! There's a small gap left of the "ABC" key, adding 0.5 to space bar width should hopefully fix that 👍
|
Greate :D did you look at my last commit? Because I noticed those issues right after my PR and fix those. Now I'm not in my computer but I'll check again asap |
|
Yep, I checked out the last commit on your PR. Perhaps that fix wasn't pushed upstream? |
|
Also, something that worries me is that now the "Hide" button placement is going to be inconsistent, i.e. it'll be in one place on the first 2 layers, and in a different place on the rest of the PT layers as well as all other language layouts. I understand why you wanted to move it to a different spot, but I'm a bit worried that having to remember where it is on different layers might get annoying. |
You're right. I'll think about that as well |



Add extended pt layout