Look up images based users localisation#15
Open
stevenoglesby wants to merge 1 commit intonicklockwood:masterfrom
Open
Look up images based users localisation#15stevenoglesby wants to merge 1 commit intonicklockwood:masterfrom
stevenoglesby wants to merge 1 commit intonicklockwood:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the requested image is not found in the resourcePath then we then look up based on paths in the users preferredLocalizations in order and finally look in the Base localisation path.
So we should find images for correct language (variant etc) as primary lookup and then at the best size for the device in that language as secondary lookup. Which is hopefully what the user would want.