fix: check ctx.ui existence when hasUI is false#4
Open
snqb wants to merge 1 commit intonicobailon:mainfrom
Open
fix: check ctx.ui existence when hasUI is false#4snqb wants to merge 1 commit intonicobailon:mainfrom
snqb wants to merge 1 commit intonicobailon:mainfrom
Conversation
When running 'pi' directly with a TTY, ctx.hasUI can sometimes be false even though the TUI is fully functional and ctx.ui is available. This fix allows the interactive shell to work if ctx.ui exists, regardless of the hasUI flag.
Author
|
hey, fully vibe-coded and vibe-discovered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
pidirectly with a TTY,ctx.hasUIcan sometimes befalseeven though the TUI is fully functional andctx.uiis available.This causes the tool to return:
Solution
Check for
ctx.uiexistence as a fallback whenhasUIis false. If the UI object exists, overlay methods will work.Changes
This is a non-breaking change - the check is now more permissive, allowing the tool to work in edge cases where the TUI is available but the flag is incorrectly set.