Skip to content

Conversation

@bacosmin
Copy link

@bacosmin bacosmin commented Oct 4, 2017

I have extracted each message into a separate class that extends a base class.
The validation method tries to use the user message class, if is not present it fallbacks to the rails_param default messages

@iMacTia
Copy link
Collaborator

iMacTia commented May 29, 2018

I like the idea of having a custom message option, but the refactoring looks too much convoluted to me (and very much Java-like...).
Moreover, we're planning a refactoring of validations based on ActiveModel so I'll come back to this after we're done with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants