Skip to content

Conversation

@StarFleetCPTN
Copy link

@StarFleetCPTN StarFleetCPTN commented Jan 25, 2026

Summary

Pushover supports 5 priority levels but the notification form only had 3 options. This adds the missing priority levels:

  • Lowest (-2) - No notification/alert, just appears in the app
  • Emergency (2) - Repeats until acknowledged by the user

Changes

  • Updated the priority dropdown in the Pushover form to include all 5 levels
  • Updated the schema validation to accept the full range (-2 to 2)

Testing

  • Verified the form displays all priority options correctly
  • Confirmed schema validates the new priority values

Summary by CodeRabbit

  • New Features
    • Added two new priority levels to Pushover notifications: Lowest (-2) and Emergency (2). This enhancement expands the available notification priority configuration options, allowing for greater flexibility in alert routing and overall notification handling. Users can now implement more nuanced prioritization strategies based on specific urgency levels and various alert type requirements.

✏️ Tip: You can customize this high-level summary in your review settings.

Add lowest (-2) and emergency (2) priority options to the Pushover
notification form. Previously only low, normal, and high were available.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Expanded Pushover notification priority support by adding two new priority levels: Lowest (-2) and Emergency (2). Updated the form component to display these options and extended schema validation to accept the wider priority range.

Changes

Cohort / File(s) Summary
Pushover priority levels expansion
app/client/modules/notifications/components/notification-forms/pushover-form.tsx, app/schemas/notifications.ts
Added Lowest (-2) and Emergency (2) priority options to the Pushover form select element. Extended schema validation for the priority field from -1 | 0 | 1 to -2 | -1 | 0 | 1 | 2 to accommodate the new priority range.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding support for all priority levels to the Pushover notification feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nicotsx
Copy link
Owner

nicotsx commented Jan 25, 2026

Thank you @StarFleetCPTN

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants