Skip to content

Add bounces prop #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add bounces prop #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ In wrapping around the ScrollView and using the TextInput to control keyboard we
| contentInset | `{top: 0, left: 0, bottom: 0, right: 0}` | `object` | Set to the ScrollView contentInset prop |
| onScroll | `() => {}` | `func` | Set to the ScrollView onScroll function. It will be called alongside our own |
| onRefFocus | `()=>{}` | `func` | Gives back the 'ref' of the node whenever a smart component is focused |
| bounces | `()=>{}` | `bool` | Controls bouncing of the underlying ScrollView |

#### Smart Component Props

Expand Down
6 changes: 4 additions & 2 deletions SmartScrollView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ class SmartScrollView extends Component {
zoomScale,
showsVerticalScrollIndicator,
contentInset,
onScroll
onScroll,
bounces,
} = this.props;
let inputIndex = 0;
const smartClone = (element, i) => {
Expand Down Expand Up @@ -238,7 +239,7 @@ class SmartScrollView extends Component {
zoomScale = { zoomScale }
showsVerticalScrollIndicator = { showsVerticalScrollIndicator }
keyboardShouldPersistTaps = { true }
bounces = { false }
bounces = { bounces }
>
{content}
</ScrollView>
Expand All @@ -263,6 +264,7 @@ SmartScrollView.propTypes = {
contentInset: PropTypes.object,
onScroll: PropTypes.func,
onRefFocus: PropTypes.func,
bounces: PropTypes.bool,
};

SmartScrollView.defaultProps = {
Expand Down