Skip to content

Conversation

@hairyhenderson
Copy link

Fixes #42, potentially.

After I realized that the VERSION grammar didn't support anything other than x.y.z form versions, the issues I've been having with prerelease identifiers make much more sense!

I've made a few changes to fix this:

  • took the BNF grammar from semver.org and done a direct translation to ANTLR in SemverGrammar.g4
  • updated parser/gen.sh to support either antlr4 or antlr commands (it's the latter on my system, but can't assume the same elsewhere)
  • added a few new unit tests to confirm correct semver comparison behaviours
  • updated dependency to github.com/blang/semver/v4

Hopefully this all makes sense, and can be merged quickly!

Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logic error when evaluating with semvers

1 participant