Handle blocked access to local/session storage #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables proper handling of blocked storage access for
localStorageandsessionStoragein browsers with increased privacy settings or some private browsing modes.Currently the Keyguard throws a
Key not founderror from the iframe, after the user already entered their password.This PR makes it so the Keyguard simply ignores blocked access to storage if not necessary for the Keyguard to function (TabWidthSelector, RpcServer), but fails with a new
BrowserErrortype when it is required, as during import when we want to temporarily store the seed insessionStorageso that we can derive all addresses during discovery in the Hub.