- 
                Notifications
    You must be signed in to change notification settings 
- Fork 536
Fix nipy#3653 and nipy#3654 in the CAT12 Interface #3683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
- Coverage   70.89%   70.54%   -0.36%     
==========================================
  Files        1277     1277              
  Lines       59212    59223      +11     
  Branches     9799     9804       +5     
==========================================
- Hits        41980    41779     -201     
- Misses      16066    16292     +226     
+ Partials     1166     1152      -14     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
…ted if statements for when no surface or ROI estimations are desired
| True, | ||
| field="output.ROImenu.atlases.neuromorphometrics", | ||
| usedefault=True, | ||
| # usedefault=True, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't change the interface like this. The reason to have defaults expliciltly added is so that when tools change their defaults, old workflows that depended on those defaults would continue using the old settings.
If the changes are this extensive, new interfaces will be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted before, any changes must be backwards compatible. If this cannot be done in the current interface, a new interface must be written.
Summary
Fixes nipy#3653 and nipy#3654.
List of changes proposed in this PR (pull-request)