Skip to content

Conversation

@faukah
Copy link

@faukah faukah commented Oct 15, 2025

Move core logic to platform.rs.
Depends on #436 and #445.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • Style and consistency
    • I ran nix fmt to format my Nix code
    • I ran cargo fmt to format my Rust code
    • I have added appropriate documentation to new code
    • My changes are consistent with the rest of the codebase
  • Correctness
    • I ran cargo clippy and fixed any new linter warnings.
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas to explain the
      logic
    • I have documented the motive for those changes in the PR body or commit
      description.
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

faukah added 4 commits October 20, 2025 14:07
There is no point in making the attribute of an
Installable be a Vec. Attributes can are used in one of:
- Flake: FLAKEREF#ATTRIBUTE:
  Here, we cannot pass multiple attributes anyways.

- File, Expression:
  The Nix expression (in that file), or any selected attribute,
  must evaluate to a derivation.

It is fine to only accept a single attribute here,
since no one is going to add several attributes corresponding
to {nixos,home,darwin}Configurations, here.
@faukah faukah force-pushed the faukah/platform-refactor branch from a1479d6 to 6509713 Compare October 20, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant