[3611] Sync root launcher defaults and justfile with codex TUI path#3612
[3611] Sync root launcher defaults and justfile with codex TUI path#3612
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
njfio has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93c51cb8f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| REQUEST_TIMEOUT_MS_DEFAULT="${TAU_UNIFIED_REQUEST_TIMEOUT_MS:-180000}" | ||
| AGENT_REQUEST_MAX_RETRIES_DEFAULT="${TAU_UNIFIED_AGENT_REQUEST_MAX_RETRIES:-0}" |
There was a problem hiding this comment.
Renaming the defaults to TAU_UNIFIED_REQUEST_TIMEOUT_MS and TAU_UNIFIED_AGENT_REQUEST_MAX_RETRIES drops support for the previously supported TAU_UNIFIED_TUI_REQUEST_TIMEOUT_MS / TAU_UNIFIED_TUI_AGENT_REQUEST_MAX_RETRIES overrides, so existing shells/CI jobs that export the old variables are silently ignored and now run with 180000/0 instead of their configured values. This is a behavioral regression in the launcher interface and can unexpectedly change runtime latency/retry behavior for users who relied on the old env knobs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Updates the root developer entrypoints (launcher + TUI + automation) to align with the current Codex-backed runtime defaults, and adds a root justfile to make the root checkout the primary workflow surface.
Changes:
- Update
scripts/run/tau-unified.shdefaults togpt-5.3-codexand new timeout/retry defaults, forwarding those flags totau-coding-agent. - Update
tau-tuiagent-mode defaults/tests so--dry-runemitsgpt-5.3-codex. - Add a root
justfileplus a contract test script to validate the root launcher/just entrypoint wiring.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
specs/3611-root-dev-launcher-sync.md |
Adds a spec-like document describing the desired root launcher/justfile alignment. |
scripts/run/test-tau-unified.sh |
Updates contract assertions to validate new default model/timeout/retry flags. |
scripts/run/tau-unified.sh |
Changes unified launcher defaults and adds/validates new timeout & retry flags for runtime and TUI paths. |
scripts/dev/test-root-just-launcher.sh |
Adds a contract test to validate root justfile recipes exist and dry-run to the launcher. |
justfile |
Introduces root recipes for stack lifecycle, TUI launch, and session reset flows. |
crates/tau-tui/src/main.rs |
Updates agent-mode default model and adjusts associated CLI tests/help text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # 3611-root-dev-launcher-sync | ||
|
|
||
| ## Objective | ||
| Align the root repo developer entrypoints with the current Codex-backed interactive runtime so the root checkout is the authoritative path for starting, restarting, and testing the Tau TUI stack. | ||
|
|
There was a problem hiding this comment.
This spec file doesn’t follow the repo’s binding spec contract (specs/<issue-id>/spec.md) and it’s missing a Status: line. scripts/dev/spec-archive-index.sh only scans specs/*/spec.md and extracts Status:, so this spec won’t be indexed and will show up as Unknown status.
| REQUEST_TIMEOUT_MS_DEFAULT="${TAU_UNIFIED_REQUEST_TIMEOUT_MS:-180000}" | ||
| AGENT_REQUEST_MAX_RETRIES_DEFAULT="${TAU_UNIFIED_AGENT_REQUEST_MAX_RETRIES:-0}" |
There was a problem hiding this comment.
The launcher renamed the TUI env overrides to TAU_UNIFIED_REQUEST_TIMEOUT_MS / TAU_UNIFIED_AGENT_REQUEST_MAX_RETRIES, but existing docs still reference TAU_UNIFIED_TUI_REQUEST_TIMEOUT_MS / TAU_UNIFIED_TUI_AGENT_REQUEST_MAX_RETRIES. Consider supporting the previous env var names as fallbacks (or updating the docs in this PR) to avoid a breaking change for current users.
| REQUEST_TIMEOUT_MS_DEFAULT="${TAU_UNIFIED_REQUEST_TIMEOUT_MS:-180000}" | |
| AGENT_REQUEST_MAX_RETRIES_DEFAULT="${TAU_UNIFIED_AGENT_REQUEST_MAX_RETRIES:-0}" | |
| REQUEST_TIMEOUT_MS_DEFAULT="${TAU_UNIFIED_REQUEST_TIMEOUT_MS:-${TAU_UNIFIED_TUI_REQUEST_TIMEOUT_MS:-180000}}" | |
| AGENT_REQUEST_MAX_RETRIES_DEFAULT="${TAU_UNIFIED_AGENT_REQUEST_MAX_RETRIES:-${TAU_UNIFIED_TUI_AGENT_REQUEST_MAX_RETRIES:-0}}" |
| stack-up-fast: | ||
| @echo "starting unified runtime (reuse credentials)" | ||
| {{TAU_ENV}}; ./scripts/run/tau-unified.sh up --auth-mode localhost-dev --model gpt-5.3-codex | ||
|
|
There was a problem hiding this comment.
This recipe hard-codes --model gpt-5.3-codex even though tau-unified.sh up now defaults to that model. To avoid the justfile becoming stale again when defaults change, consider relying on launcher defaults (omit --model) or centralize the value in a single just variable used by all recipes.
|
|
||
| tui: | ||
| @echo "launching tau tui from root path" | ||
| {{TAU_ENV}}; ./scripts/run/tau-unified.sh tui --model gpt-5.3-codex --request-timeout-ms 180000 --agent-request-max-retries 0 |
There was a problem hiding this comment.
The tui recipe pins --model/--request-timeout-ms/--agent-request-max-retries explicitly even though tau-unified.sh tui now defaults to these values. Keeping them duplicated here increases drift risk; consider calling ./scripts/run/tau-unified.sh tui without redundant flags (or define shared variables for the pinned values).
| {{TAU_ENV}}; ./scripts/run/tau-unified.sh tui --model gpt-5.3-codex --request-timeout-ms 180000 --agent-request-max-retries 0 | |
| {{TAU_ENV}}; ./scripts/run/tau-unified.sh tui |
Closes #3611
Issue: #3611
Spec:
specs/3611-root-dev-launcher-sync.mdWhat changed:
tau-unified.shdefaults to the current Codex-backed model and launcher timeout/retry policytau-tuiagent defaults/help text to emitgpt-5.3-codexin dry-run modejustfilefor stack up/down/restart/rebuild/tui/fresh-session flowsjustfileTest evidence:
cargo test -p tau-tuibash scripts/run/test-tau-unified.shbash scripts/dev/test-root-just-launcher.shcargo run -p tau-tui -- agent --dry-run --no-colorjust stack-up-fast/./scripts/run/tau-unified.sh status/just stack-down