Add _from_bytes methods to allow the direct usage of u8 byte arrays#1
Open
olliecheng wants to merge 2 commits intonlhepler:mainfrom
Open
Add _from_bytes methods to allow the direct usage of u8 byte arrays#1olliecheng wants to merge 2 commits intonlhepler:mainfrom
olliecheng wants to merge 2 commits intonlhepler:mainfrom
Conversation
…ithout ffi conversion
Author
|
I believe that this enables better interoperability with other Rust tools and libraries. For instance, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work on making this wrapper! This PR adds
align_from_bytesandadd_alignment_from_bytesversions of the existingAlignmentEngine::alignandGraph::add_alignmentmethods, which take in a&[u8]byte slice instead of aCStr.