Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
c48e891
first commit for B-H with ab
Rick-Methot-NOAA Feb 9, 2023
fdfdf82
revise to use WHAM syntax
Rick-Methot-NOAA Feb 14, 2023
9119b3d
Update .gitignore
Rick-Methot-NOAA Feb 14, 2023
d6aa468
Srr=10 now matching SRR=3
Rick-Methot-NOAA May 19, 2023
f8533ca
adding reporting for timevary growth
Rick-Methot-NOAA May 20, 2023
a1722eb
WIP
Rick-Methot-NOAA May 31, 2023
ab567cf
working version with a,b
Rick-Methot-NOAA May 22, 2024
83d5b71
Update .gitignore
May 28, 2024
4f96850
augment spawn_recr report and use to test time-vary SR_parm approach
Rick-Methot-NOAA Jun 12, 2024
707aa32
adding benchmark change
Rick-Methot-NOAA Jun 26, 2024
1034c6e
format changes for spawn_recr report
Rick-Methot-NOAA Jul 3, 2024
edc7ca9
fixes to ss_warn
Rick-Methot-NOAA Jul 9, 2024
d11c35f
WIP-more work needed on benchmark calcs
Rick-Methot-NOAA Aug 14, 2024
545bb59
WIP2-need-to-fix-SPR-passing_to_benchmark
Rick-Methot-NOAA Aug 16, 2024
2bd30c2
WIP: add switch in benchmark to use correct SPR0
Rick-Methot-NOAA Sep 13, 2024
5521615
refactor SPR to SSBpR; clean-up reference to timevary biology
Rick-Methot-NOAA Sep 17, 2024
c04d9b4
create new switch to control updating of SSBpR0
Rick-Methot-NOAA Sep 20, 2024
1d2e75a
too many changes
Rick-Methot-NOAA Oct 4, 2024
72bac37
add HCR_anchor in forecast.ss
Rick-Methot-NOAA Oct 4, 2024
1712c7c
revert change in capitalization of Recr_Virgin
iantaylor-NOAA Oct 18, 2024
7ffbff5
latest update
Rick-Methot-NOAA Oct 17, 2024
7f14cd6
add 3 lines to mgmt_quant
Rick-Methot-NOAA Jan 23, 2025
cec0404
add 4 lines to mgmt_quant to display more benchmark quantities
Rick-Methot-NOAA Feb 20, 2025
f232d53
assure align of SRR curve and SPR/YPR profile
Rick-Methot-NOAA Feb 22, 2025
e69f40e
adjust SPR in profile to match old approach
Rick-Methot-NOAA Feb 25, 2025
806611f
WIP
Rick-Methot-NOAA Mar 11, 2025
8676e7a
still a WIP
Rick-Methot-NOAA Mar 13, 2025
e8953f8
add backward compat flag to starter
Rick-Methot-NOAA Mar 14, 2025
5bcfa05
WIP - new approach not showing difference
Rick-Methot-NOAA Mar 20, 2025
013a176
by jove, I think he did it
Rick-Methot-NOAA Mar 21, 2025
0bc8855
align depletion_basis and Btarget and HCR anchor
Rick-Methot-NOAA Mar 26, 2025
1b251cd
rename Do_Equil_Calc; remove erroneous application of regime in initi…
Rick-Methot-NOAA Mar 27, 2025
0ad975f
revise SRparm timevary to track R0 h
Rick-Methot-NOAA Mar 28, 2025
d134312
refactor variable names and continue testing
Rick-Methot-NOAA Mar 31, 2025
a101320
timevary_SRparm_controls_working
Rick-Methot-NOAA Apr 3, 2025
bf0931b
start cleanup reporting to Spawn_Recr table
Rick-Methot-NOAA Apr 4, 2025
aa4eab0
add SPR_reporting option 5
Rick-Methot-NOAA Apr 25, 2025
2beff82
clean up ss_new and spawn_recr output
Rick-Methot-NOAA May 16, 2025
0a5451d
Change approach for invoking Bmsy as the HCR_inflection
Rick-Methot-NOAA May 22, 2025
9d83300
git stash pop
Rick-Methot-NOAA Jun 3, 2025
eaba263
redo code for Bmsy as HCR inflection
Rick-Methot-NOAA Jun 3, 2025
37db2c9
add bench SR_curve; cleanup spawn_recr report
Rick-Methot-NOAA Jun 3, 2025
7ea4fde
easy fix for spiny dogfish using SRR 7
Rick-Methot-NOAA Jun 6, 2025
2e35ec3
repair legacy HCR_anchor; cleanup warnings
Rick-Methot-NOAA Jun 11, 2025
c5381f4
restore global_msy to report.sso
Rick-Methot-NOAA Jun 11, 2025
03df832
fix par file line in starter to match new text
e-perl-NOAA Jun 11, 2025
28c2df8
fix forecast file removal line
e-perl-NOAA Jun 11, 2025
8ab8244
try different fix to starter file lines
e-perl-NOAA Jun 12, 2025
c744d30
fix logic for reading of timevary_bio_4SRR
Rick-Methot-NOAA Jun 16, 2025
cf6b0c5
Update run-ss3-no-est.yml with updated t-v models test models branch
e-perl-NOAA Jun 26, 2025
abeda19
Update run-ss3-with-est.yml
e-perl-NOAA Jun 26, 2025
9231935
Update run-ss3-with-est.yml with simple PR trigger
e-perl-NOAA Jun 26, 2025
7d972b3
minor changes to capitalization
iantaylor-NOAA Jun 26, 2025
3e749c0
temporarily changing the r4ss install in test to use branch
iantaylor-NOAA Jun 26, 2025
ec03c54
Update run-ss3-with-est.yml
e-perl-NOAA Jun 30, 2025
3765052
revise mgmt_quant labels; fix wt_age_mid for global
Rick-Methot-NOAA Jun 30, 2025
fe43c46
rework logic in bench; revise the extra mgmt_quant
Rick-Methot-NOAA Jul 3, 2025
53a6c3e
return to using main test branch repo for ghas
e-perl-NOAA Jul 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/run-ss3-no-est.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,15 @@ jobs:
on.exit(system(paste0("cd ", wd)))
# delete old starter files, rename forecast.ss_new and starter.ss_new files
file.remove(file.path(dir, "starter.ss"))
file.remove(file.path("forecast.ss"))
file.remove(file.path(dir, "forecast.ss"))
file.rename(file.path(dir, "starter.ss_new"), file.path(dir,"starter.ss"))
file.rename(file.path(dir, "forecast.ss_new"), file.path(dir,"forecast.ss"))
# rename control and data files to standardized names (from the starter files)
start <- readLines(file.path(dir, "starter.ss"))
first_val_line <- grep("0=use init values in control file", start, fixed = TRUE)
datname <- start[first_val_line-2]
ctlname <- start[first_val_line-1]
datname <- start[grep("#_datfile", start, fixed = TRUE)]
datname <- gsub(" #_datfile", "", datname)
ctlname <- start[grep("#_ctlfile", start, fixed = TRUE)]
ctlname <- gsub(" #_ctlfile", "", ctlname)
print(datname)
print(ctlname)
file.remove(file.path(dir, datname))
Expand Down
22 changes: 10 additions & 12 deletions .github/workflows/run-ss3-with-est.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Build SS3 and run test models with estimation and hessian
# Only runs manual run or if run-ss3-no-est.yml runs successfully
name: run-ss3-with-est
on:
workflow_dispatch:
Expand All @@ -8,21 +7,20 @@ on:
# - '**.tpl'
# branches:
# - main
workflow_run:
workflows: ["run-ss3-no-est"]
types:
- completed
# pull_request:
# types: ['opened', 'edited', 'reopened', 'synchronize', 'ready_for_review']
# paths:
# - '**.tpl'
# branches:
# - main
# workflow_run:
# workflows: ["run-ss3-no-est"]
# types:
# - completed
pull_request:
paths:
- '**.tpl'
branches:
- main

# Run fast running SS3 test models with estimation
jobs:
run-ss3-with-est:
if: ${{ github.event_name == 'workflow_dispatch' || (github.event.pull_request.draft == 'false' && github.event.workflow_run.conclusion == 'success') }}
# if: ${{ github.event_name == 'workflow_dispatch' || (github.event.pull_request.draft == 'false'}}
runs-on: ubuntu-latest
env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-r4ss-with-ss3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
run: Rscript -e 'install.packages(c("remotes","parallely", "furrr", "future"))'

- name: Install r4ss
run: Rscript -e 'remotes::install_github("r4ss/r4ss")'
run: Rscript -e 'remotes::install_github("r4ss/r4ss@expanded_SR")'

# - name: Get admb and put in path, linux
# run: |
Expand Down
9 changes: 5 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
*.htp
*.obj
*.log
ss.tpl
ss3.tpl
ss_opt.tpl
ss_trans.tpl
Compile/ss.tpl
Compile/ss_opt.tpl
Compile/ss_trans.tpl
Compile/ss3.tpl
Compile/Make_SS_warn.bat
~$*.*
Compile/ss.log
Compile/ss3.log
Expand Down
2 changes: 1 addition & 1 deletion Compile/Make_SS_warn.bat
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ tpl2cpp ss3

g++ -c -std=c++17 -O2 -D_FILE_OFFSET_BITS=64 -DUSE_ADMB_CONTRIBS -D_USE_MATH_DEFINES -I. -I"C:\ADMB-13.2\include" -I"C:\ADMB-13.2\include\contrib" -Wall -Wextra -o ss3.obj ss3.cpp

g++ -static -o ss3.exe ss3.obj "C:\ADMB-13.2\lib\libadmb-contrib-mingw64-g++12.a"
g++ -static -o ss3.exe ss3.obj "C:\ADMB-13.2\lib\libadmb-contrib-mingw64-g++13.a"

dir *.exe
Loading
Loading