age-based calc of sel_dead_num and bio is repaired#663
Merged
Rick-Methot-NOAA merged 2 commits intomainfrom Apr 1, 2025
Merged
age-based calc of sel_dead_num and bio is repaired#663Rick-Methot-NOAA merged 2 commits intomainfrom
Rick-Methot-NOAA merged 2 commits intomainfrom
Conversation
e-perl-NOAA
reviewed
Apr 1, 2025
iantaylor-NOAA
approved these changes
Apr 1, 2025
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
The code changes look good to me, but I would leave it to @chantelwetzel-noaa to confirm that the results for her model look accurate.
Collaborator
Author
|
good suggestion Elizabeth to clean up the code comments, some of which were copied between sections. |
chantelwetzel-noaa
approved these changes
Apr 1, 2025
chantelwetzel-noaa
left a comment
chantelwetzel-noaa
left a comment
There was a problem hiding this comment.
I tested the model and the values in the catch table are as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
What tests have been done?
when use age-based selectivity, retention and discard mortality, the results now appear correct with the sel_dead values intermediate between the sel and the sel*ret values
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).