Skip to content

first commit for mirroring age retention#677

Merged
Rick-Methot-NOAA merged 3 commits intomainfrom
check_mirror_age_retention
May 16, 2025
Merged

first commit for mirroring age retention#677
Rick-Methot-NOAA merged 3 commits intomainfrom
check_mirror_age_retention

Conversation

@Rick-Methot-NOAA
Copy link
Collaborator

Concisely describe what has been changed/addressed in the pull request.

Implements a tested update of the mirroring of age-discard parameters

What tests have been done?

Where are the relevant files?

files provided by @chantelwetzel-noaa

What tests/review still need to be done?

close examination of output by reviewer

Is there an input change for users to Stock Synthesis?

<-- - [x] No, there was no input change. -->

Additional information (optional).

@chantelwetzel-noaa
Copy link

I have confirmed that everything now appears to be working as expected. The initial r4ss github action failed for this pull request, but I have confirmed that I was able to use SS_output(), SS_plots(), and SSsummarize() on my installed r4ss version.

@iantaylor-NOAA
Copy link
Contributor

I have confirmed that everything now appears to be working as expected. The initial r4ss github action failed for this pull request, but I have confirmed that I was able to use SS_output(), SS_plots(), and SSsummarize() on my installed r4ss version.

I'm guessing this was just a random error installing the r4ss package. I've just restarted the actions.

@e-perl-NOAA
Copy link
Collaborator

@iantaylor-NOAA It seems that even more ubuntu libraries need to be added to get r4ss working. Idk what they keep doing to the ubuntu runners that is requiring more and more libraries to need to be installed to get certain R packages to work.

@iantaylor-NOAA
Copy link
Contributor

@iantaylor-NOAA It seems that even more ubuntu libraries need to be added to get r4ss working. Idk what they keep doing to the ubuntu runners that is requiring more and more libraries to need to be installed to get certain R packages to work.

Thank you @e-perl-NOAA!

Copy link
Collaborator

@e-perl-NOAA e-perl-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave the final approval up to @chantelwetzel-noaa but all actions are now passing.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit b8a5b59 into main May 16, 2025
7 checks passed
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the check_mirror_age_retention branch May 16, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: mirroring was not working for age discard

4 participants