Merged
Conversation
Collaborator
|
@Rick-Methot-NOAA, would you like me to proceed with the release before this is merged, or wait until after? |
Contributor
|
@e-perl-NOAA, if I can sort out r4ss this morning, I think the ideal would be to merge this last change to SS3 first, but I guess it's not a big deal either way. |
Collaborator
|
@iantaylor-NOAA Okay, I will hold off on the release until I hear from you if it's possible to get the r4ss issue resolved today. |
iantaylor-NOAA
approved these changes
Sep 10, 2025
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
The r4ss changes needed to work correctly when there's only the new expanded table have now been merged (in r4ss/r4ss#1053), so this looks good to go.
iantaylor-NOAA
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
deprecate old spawn_recr table to test r4ss
What tests have been done?
verify that old table is gone
Where are the relevant files?
What tests/review still need to be done?
Is there an input change for users to Stock Synthesis?
Additional information (optional).