adjust the Lmin test for t0 users; more comments in code#727
adjust the Lmin test for t0 users; more comments in code#727Rick-Methot-NOAA merged 5 commits intomainfrom
Conversation
|
@Rick-Methot-NOAA Do you think anything needs to be added to the user manual for this? |
|
working on a gdoc now with suggested text. I cannot find in the manual where the reading of the Amin factor happens. |
|
@Rick-Methot-NOAA It's in the control section in the table in the growth section. Search for Growth Amin (A1) |
|
Got it. So I need to decide whether to expand the Timing section 8.5.2.1 to provide context for growth_Amin, or whether to just expand the growth_Amin text, even though it is presented as an "example". |
|
I guess you could also make a separate section below timing to put Jason's text with your edits. Wherever you put the text, it can be hyperlinked elsewhere. |
1 similar comment
|
I guess you could also make a separate section below timing to put Jason's text with your edits. Wherever you put the text, it can be hyperlinked elsewhere. |
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
I've skimmed through the code changes and everything looks OK on first glance.
If @shcaba finds that the revised executable works adequately well for models with t0 at length = 0 and it passes the other standardized tests, then I think it's good to merge.
|
The tests I had been doing have been working. |
Concisely describe what has been changed/addressed in the pull request.
What tests have been done?
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
testing assigned to @shcaba
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).