first commit for protection level#729
Merged
Rick-Methot-NOAA merged 2 commits intomainfrom Sep 18, 2025
Merged
Conversation
iantaylor-NOAA
approved these changes
Sep 17, 2025
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
This looks good. We will need to modify the r4ss functions for reading and writing the input files, but that shouldn't take long.
Rick-Methot-NOAA
deleted the
728-feature-add-protection-level-to-control-rule-options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
What tests have been done?
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
Basic testing done. Detailed testing will be by AEP
What tests/review still need to be done?
Detailed testing will be by AEP
Is there an input change for users to Stock Synthesis?
<-- - [x] The input change is in the related issue(s). -->
Additional information (optional).