fix timevary_SRparm for styr-1 start#737
Merged
Rick-Methot-NOAA merged 1 commit intomainfrom Oct 1, 2025
Merged
Conversation
Rick-Methot-NOAA
added
bug
iantaylor-NOAA
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
A user noted that timevary ln(R0) was not working correctly if the block started in styr-1, rather than starting during the time series. This is fixed by a small change to the creation of timevary_SRparm(y) in readcontrol
What tests have been done?
Rick tested using an example from Andre with a blovk on ln(R0) starting in styr-1
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
Andre will be testing
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).