move calc of HCR_anchor issue #743

[Rick-Methot-NOAA]

Concisely describe what has been changed/addressed in the pull request.

Move calculation of HCR_anchor to allow correct function in mceval

• Resolves [Bug]: missing values for forecast derived quantities in MCMC #743

What tests have been done?

Where are the relevant files?

<-- - [x] Test files are in the issue. -->

What tests/review still need to be done?

none

Is there an input change for users to Stock Synthesis?

Additional information (optional).

[iantaylor-NOAA]

I don't understand why this fixed worked, but it's a simple change to remove the echoinput with zero potential side effects problems, and seems to have fixed the issue for me.

[Rick-Methot-NOAA]

The fix was to move the code for calc of HCR_anchor out of the conditional if(show_MSY==1).

[iantaylor-NOAA]

@Rick-Methot-NOAA, is there an additional change that didn't get committed?
Under "Files changed" https://github.com/nmfs-ost/ss3-source-code/pull/744/files I'm only seeing removal of the echoinput line:

[Rick-Methot-NOAA]

I messed up my github action so accidentally committed the real change to main first.

[iantaylor-NOAA]

Aha, no wonder the fix worked. No problem.

[Rick-Methot-NOAA]

@e-perl-NOAA Please check to see if the history is OK.

[e-perl-NOAA]

I've squashed the two commits so the history is good to go now.