Skip to content

Consistent labels#201

Merged
sbreitbart-NOAA merged 10 commits intomainfrom
consistent-labels
Mar 3, 2026
Merged

Consistent labels#201
sbreitbart-NOAA merged 10 commits intomainfrom
consistent-labels

Conversation

@sbreitbart-NOAA
Copy link
Collaborator

@sbreitbart-NOAA sbreitbart-NOAA commented Mar 2, 2026

As per #163:

  • Remove duplicated write_caption() function
  • Update plotting functions to export rdas with filenames that match labels in caption_alt_text.csv
  • Update topic_label in plotting functions so that it is created automatically as a reflection of the function title (in cases without a relative option)
  • Update add_more_key_quants() as necessary
  • Update/add tests

…els (relative_biomass and catch comp, respectively)
…or labels (fishing_mortality and indices, respectively)
…landings, and recruitment with full names of plots for labels (spawning_biomass, recruitment_deviations, natural_mortality, landings, and recruitment, respectively)
…bnc table with full names of plots for labels (stock_recruitment, plot_indices, table_indices, plot_landings, table_landings, bnc, respectively)
… since it shouldn't cause an issue downstream
@sbreitbart-NOAA sbreitbart-NOAA linked an issue Mar 2, 2026 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

New version checklist

  • Package version in DESCRIPTION has been updated
  • Release notes have been drafted/published
  • Cheatsheet content has been updated (if applicable)
  • Cheatsheet version has been updated

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
71.1% 1:0.1 4m41s

Code coverage of files in pull request scope (85.0%)

Files Coverage
R/plot_abundance_at_age.R 76.3%
R/plot_biomass.R 95.0%
R/plot_biomass_at_age.R 76.3%
R/plot_catch_comp.R 79.2%
R/plot_fishing_mortality.R 100.0%
R/plot_indices.R 83.3%
R/plot_landings.R 100.0%
R/plot_natural_mortality.R 79.6%
R/plot_recruitment.R 63.6%
R/plot_recruitment_deviations.R 71.9%
R/plot_spawning_biomass.R 78.9%
R/plot_stock_recruitment.R 97.6%
R/table_landings.R 95.1%
R/utils_rda.R 86.0%

Reported by octocov

Copy link
Collaborator

@Schiano-NOAA Schiano-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think this is a great improvement for the user and understandability and consistency of the package

@sbreitbart-NOAA sbreitbart-NOAA merged commit f3a5da5 into main Mar 3, 2026
10 checks passed
@sbreitbart-NOAA sbreitbart-NOAA deleted the consistent-labels branch March 3, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistency in naming

2 participants