Added functionality for running on Windows, testing metadata and allowing new command line arguments #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now adds a copy of the [@metadata] field to the output called __[@metadata]. This allows testing metadata fields. - Now also produces an output file in Awesome Print format using the rubydebug codec. This is just another format in addition to the JSON file that's already produced and it's not actually used by logstash-filter-test, but it can be useful for debugging as it contains [@metadata] field and is formatted in a more human-readable way.
…of "yes" and "no". - Now accepts the new argument --logstash to set the location of the Logstash executable.
domule
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
What do you think about these enhancements?
I found your Python script incredibly useful. I was relieved to find it after getting frustrated with not being able to run logstash-filter-verifier on Windows. Since Python is a lot more accessible to me than Golang I then also made a few more changes, in particular being able to test metadata.
There are also a few other ideas that I have and would like to implement, like being able to use regexes in addition to literal string comparisons in the test case definitions. Would be great to hear your feedback on this.
Dom