feat(screen-recorder): Add Hyprland focused monitor video source#257
Open
Cleboost wants to merge 1 commit intonoctalia-dev:mainfrom
Open
feat(screen-recorder): Add Hyprland focused monitor video source#257Cleboost wants to merge 1 commit intonoctalia-dev:mainfrom
Cleboost wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
…on and environment detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhanced support for the Hyprland compositor in the
screen-recorder/Main.qmlfile, allowing for automatic detection of the focused monitor and optimized GPU usage when recording. Additionally, the codebase has been refactored for improved readability and consistency, with semicolons added and minor logic adjustments. The most important changes are grouped below:Hyprland Support and Focused Monitor Detection
isHyprland,detectedMonitor,usePrimeRun) and a process to detect if Hyprland is running, enabling special handling for Hyprland environments. [1] [2]hyprctlandjq, allowing the recorder to target the monitor under the cursor in Hyprland. If an NVIDIA GPU is detected, recording is launched withprime-runfor optimal performance. [1] [2]Refactoring and Code Consistency
launchRecorderWithSourcefunction, supporting both standard and Hyprland-specific workflows. [1] [2]Dependency Import
import Quickshell.Iotoscreen-recorder/Settings.qml, likely to support new or existing IO operations.