fix: handle spaces in video-wallpapers folder path#271
Merged
ItsLemmy merged 1 commit intonoctalia-dev:mainfrom Feb 17, 2026
Merged
fix: handle spaces in video-wallpapers folder path#271ItsLemmy merged 1 commit intonoctalia-dev:mainfrom
ItsLemmy merged 1 commit intonoctalia-dev:mainfrom
Conversation
Contributor
|
@spiros132 - this PR modifies your plugin. Please review when you have a chance. |
Contributor
|
Thank you for the PR, looks good @ItsLemmy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the Video Wallpaper plugin fails to list any videos if the selected wallpapers folder path contains spaces (e.g.,
~/Videos/Video Walls).The Problem
The plugin uses a shell-based
findcommand in to list video files. The folder variable was not quoted, causing the shell to split the path into multiple arguments, resulting in a "No such file or directory" error.The Fix
${root.folder}in thefindcommand.-mindepth 1to ensure the directory itself isn't returned in the results.Verification
Verified manually by running the corrected command against a folder named
Video Walls. The command now correctly returns the list of video files instead of throwing an error.