Skip to content

fix: handle spaces in video-wallpapers folder path#271

Merged
ItsLemmy merged 1 commit intonoctalia-dev:mainfrom
Ronin-CK:Bug-fix
Feb 17, 2026
Merged

fix: handle spaces in video-wallpapers folder path#271
ItsLemmy merged 1 commit intonoctalia-dev:mainfrom
Ronin-CK:Bug-fix

Conversation

@Ronin-CK
Copy link
Contributor

Summary

This PR fixes an issue where the Video Wallpaper plugin fails to list any videos if the selected wallpapers folder path contains spaces (e.g., ~/Videos/Video Walls).

The Problem

The plugin uses a shell-based find command in to list video files. The folder variable was not quoted, causing the shell to split the path into multiple arguments, resulting in a "No such file or directory" error.

The Fix

  • Added double quotes around ${root.folder} in the find command.
  • Added -mindepth 1 to ensure the directory itself isn't returned in the results.

Verification

Verified manually by running the corrected command against a folder named Video Walls. The command now correctly returns the list of video files instead of throwing an error.

// common/FolderModel.qml
let command = `find "${root.folder}" -mindepth 1 -maxdepth 1`

@github-actions
Copy link
Contributor

@spiros132 - this PR modifies your plugin. Please review when you have a chance.

@Ronin-CK Ronin-CK marked this pull request as ready for review February 17, 2026 15:23
@Ronin-CK Ronin-CK changed the title fix: handle spaces in wallpapers folder path fix: handle spaces in video-wallpapers folder path Feb 17, 2026
@spiros132
Copy link
Contributor

Thank you for the PR, looks good @ItsLemmy :)

@ItsLemmy ItsLemmy merged commit 7498009 into noctalia-dev:main Feb 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments