Skip to content

fix(privacy-indicator): use StdioCollector to read camera detection output#273

Merged
Ly-sec merged 1 commit intonoctalia-dev:mainfrom
cyril-marpaud:patch-1
Feb 17, 2026
Merged

fix(privacy-indicator): use StdioCollector to read camera detection output#273
Ly-sec merged 1 commit intonoctalia-dev:mainfrom
cyril-marpaud:patch-1

Conversation

@cyril-marpaud
Copy link
Contributor

Problem

Camera detection was not working on Ubuntu. Process.stdout in Quickshell is not a string property — it expects a parser object. Reading stdout in onExited always returned nothing, so camActive stayed false.

Fix

Replace the onExited handler with a StdioCollector on the stdout property, reading the output via this.text in onStreamFinished.

Notes

  • Tested on Ubuntu with Quickshell 0.2.1 — camera now detected correctly
  • The old approach apparently worked on NixOS (different Quickshell version?), but this fix aligns with the documented API
  • I have not been able to test on NixOS
  • This was vibe-coded, please review carefully

@github-actions
Copy link
Contributor

@Ly-sec - this PR modifies your plugin. Please review when you have a chance.

@Ly-sec Ly-sec merged commit 48c7b9b into noctalia-dev:main Feb 17, 2026
1 check passed
@Ly-sec
Copy link
Contributor

Ly-sec commented Feb 17, 2026

Looks good to me, merged it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments