Skip to content

Conversation

@nschonni
Copy link
Member

Description

Pin SHAs according to https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions.
Adding additional permissions config for some of the missing jobs might make sense.

Motivation and Context

Some cleanup related to #2208

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot knows how to update these, right?

@forsen
Copy link

forsen commented Mar 17, 2025

dependabot knows how to update these, right?

Yep, implemented in dependabot/dependabot-core#5951

@nschonni nschonni merged commit ebe23e5 into nodejs:main Mar 17, 2025
2 checks passed
@nschonni nschonni deleted the harden-ci branch March 17, 2025 14:05
@github-actions
Copy link

Created PR on the official-images repo (docker-library/official-images#18646). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants