Merged
Conversation
anonrig
commented
Feb 3, 2026
56cf070 to
4300192
Compare
harrishancock
approved these changes
Feb 3, 2026
4300192 to
d628ab0
Compare
Member
Author
aduh95
approved these changes
Feb 4, 2026
Contributor
aduh95
left a comment
There was a problem hiding this comment.
I don't know about MSVC flags, the rest LGTM
targos
reviewed
Feb 4, 2026
| /wd4100 # Unreferenced formal parameter (like -Wno-unused-parameter) | ||
| /wd4267 # Conversion from 'size_t' to smaller type | ||
| /wd4244 # Conversion, possible loss of data | ||
| /wd4305 # Truncation from 'int' to 'bool' |
Member
There was a problem hiding this comment.
Doesn't it make sense to fix these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables more strict compiler flags to avoid warnings like this: